The first thing to consider when organising your music files is how will you store them?
I'll add a couple below along with what I use
The simplest solution is to store your music on the device you are listening to it on. This means just storing the files on your mp3 player or computer. This is the cheapest and easiest method but can be problematic when adding or removing music as some 2000s era mp3s want you to use specific software to add music. These softwares were buggy at the time and most of them are unusable on modern windows, let alone support on macos. Even if you do get them running using linux wine or windows compatability layer, they can be super tedious to use. Even without these issues, moving the files between devices is still tedious requiring a snake of wires or dongle hell and it's often easier to download a new copy altogether
I'm combining these as there isn't much difference once all is up and running but to explain breifly: A cloud server is a storage device accessed via the internet. Think Google Drive or Apple iCloudA NAS is a cloud server you own and run locally on your own network. The differences to bear in mind is that a cloud server usually requires a monthly cost, whereas a NAS has a lengthy and difficult setup and will very slightly increase your energy bills. Personally I use a NAS running nextcloud These methods allow you to stream music with a reduced monthly fee vs music streaming or download and upload any of your music files from anywhere with an internet connection as and when. The downsides to this method is your mp3 player needs to have internet connection, and there is a risk of downtime (which you will also have to diagnose and fix with a NAS)

Probably the best of both worlds from the previous options, External storage (sd card, usb stick, etc.) Alllows you to have the ease of the cloud options without an internet access. The main issues with external storage is compatibility, your mp3 player and computer must both be able to connect to the card or stick and you can very easily end up in dongle hell, especially with recent macbooks, if this isn't possible. The second is size. Loosing an sd card is super easy, especially with spring loaded docks like both my mp3 players have. You will also have to weigh up cost or fragmentation. You can either buy an expensive card upfront and have a ton of storage on it, or buy a smaller affordable card and buy another cheap one when you fill it then have to keep track whats on what
This one depends on the size of your music collection and your idiosyncrasies. My music foldet tree looks something like ~/Music/label/artist/album with a dedicated subfolder in the music folder for singles and loose songs that are disconnected from their albums. I'm tempted to rework this folder as it's my DJing folder and want something morefit for that purpose. Potentially ~/Music/Singles/Initial_Key or ~/Music/Singles/BPM (in multiples of 10). Also for those wondering the ~ represents my home folder. The issues with my method is that bands can change record label or get signed if they started indie which means the catalogue for a certain artist can be split across different folders. I have two different folders for Dan Mason as an example. If I want to listen to Void I need to go to my Business Casual folder, if I want Forever Nothing I need my 100% ELECTRONICA folder. The same problem arises with using the more popular genre/artist/album which is how I sort my physical music. But you have the same issue, take Yeule's discography. Every album they make is a different genre, and although you could squeeze Serotonin II and Glitch Princess together into a Pop folder, Softscars is more deserving of a shoegaze / post punk classification and Evangelic Girl Is A Gun fits better with a trip hop playlist. The only solution I can think of to this is to start with your artists but then you're scrolling for forever to find someone like zovi if your file manager is alphabetically sorted. There must be some esoteric method I'm not thinking of though. Please let me know if you got any ideas here